authorgravatar for hello@nektro.netMeghan Denny <hello@nektro.net> 2026-07-17 11:43:43 -07:00
committergravatar for hello@nektro.netMeghan Denny <hello@nektro.net> 2026-07-17 11:43:43 -07:00
loge9bd5b789ffdad8f6be2c329be14e5aa4dcd678d
tree7a00ccf4e8f727521fd886fd3614fa179119c19d
parentbaef2462ff91a3156014581df267470418464ab6
signaturebadge-check Signed by SSH key SHA256:4hHJbtBRU58AYXwjL7fkz2fnQHdiye8x1QpTCQ0sHNw

Signature: ssh: explain why ssh-rsa is skipped


1 files changed, 2 insertions(+), 1 deletions(-)

git.zig+2-1
...@@ -2392,6 +2392,7 @@ pub const Signature = union(enum) {...@@ -2392,6 +2392,7 @@ pub const Signature = union(enum) {
2392 // https://datatracker.ietf.org/doc/html/rfc9580#section-42392 // https://datatracker.ietf.org/doc/html/rfc9580#section-4
2393 // https://datatracker.ietf.org/doc/html/rfc9580#signature-packet2393 // https://datatracker.ietf.org/doc/html/rfc9580#signature-packet
2394 // https://datatracker.ietf.org/doc/html/rfc56562394 // https://datatracker.ietf.org/doc/html/rfc5656
2395 // https://datatracker.ietf.org/doc/html/rfc4253
2395 pub fn fromReader(kind: NonVoidUnionFieldEnum(Signature), allocator: std.mem.Allocator, b64r: anytype, message: []const u8) !Signature {2396 pub fn fromReader(kind: NonVoidUnionFieldEnum(Signature), allocator: std.mem.Allocator, b64r: anytype, message: []const u8) !Signature {
2396 if (kind == .pgp) {2397 if (kind == .pgp) {
2397 var signed_data: nio.AllocatingWriter = .init(allocator);2398 var signed_data: nio.AllocatingWriter = .init(allocator);
...@@ -2559,7 +2560,7 @@ pub const Signature = union(enum) {...@@ -2559,7 +2560,7 @@ pub const Signature = union(enum) {
2559 _ = pkformat;2560 _ = pkformat;
25602561
2561 if (std.mem.eql(u8, sigformat, "ssh-rsa")) {2562 if (std.mem.eql(u8, sigformat, "ssh-rsa")) {
2562 // intentionally skipped2563 // intentionally skipped, rsa with sha1
2563 }2564 }
2564 if (std.mem.eql(u8, sigformat, "ssh-ed25519")) blk: {2565 if (std.mem.eql(u8, sigformat, "ssh-ed25519")) blk: {
2565 const ed = std.crypto.sign.Ed25519;2566 const ed = std.crypto.sign.Ed25519;